Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to CircleCI 2.0 #11620

Closed
wants to merge 3 commits into from

Conversation

serima
Copy link
Contributor

@serima serima commented Nov 22, 2017

For what?

Migrate to CircleCI 2.0 to speed up the build.

Docker image

CircleCI 2.0 supports docker natively.
In this pull request I tried to use starefossen/ruby-node docker image.
I thought that this was appropriate as a reliable docker image with Ruby and Node bundled.

https://hub.docker.com/r/starefossen/ruby-node/

@serima
Copy link
Contributor Author

serima commented Nov 22, 2017

Oops, I did working for this quite a while and did not notice another pull request #11605. It seems in progress, so please close this if we do not need this.

@gaearon
Copy link
Collaborator

gaearon commented Nov 28, 2017

Yup, merged that. Thanks!

@gaearon gaearon closed this Nov 28, 2017
@serima serima deleted the feature/migrate-to-circleci-20 branch May 2, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants